-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement terraform modules and infrastructure example #125
Conversation
Thanks for the pull request, @gabor-boros! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Thanks for the pull request, @gabor-boros! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Signed-off-by: Gabor Boros <[email protected]>
5e54e34
to
7441d2f
Compare
Co-authored-by: Braden MacDonald <[email protected]>
Co-authored-by: Braden MacDonald <[email protected]>
Signed-off-by: Gabor Boros <[email protected]>
Signed-off-by: Gabor Boros <[email protected]>
@bradenmacdonald could you please take another review and approve if you agree with the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabor-boros LGTM. Thanks!
@bradenmacdonald Before I merge this, I would like to highlight that this implementation has the exact same "features" that you highlighted as weaknesses in the AWS infra PR |
Signed-off-by: Gabor Boros <[email protected]> Co-authored-by: Braden MacDonald <[email protected]>
This PR implements terraform modules for DigitalOcean that allows anyone to create a production-grade infrastructure for hosting Open edX instances using Tutor and Harmony.
The PR includes a reference implementation as a usage example.